Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PB-2515]: fix/shard usecase networkqueue #163

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

jzunigax2
Copy link

@jzunigax2 jzunigax2 commented Aug 19, 2024

After contactsRepository was added as a paramter to shardUseCase constructor, two references were not updated. This caused errors in bucket controller, specifically in removeFile where this.networkQueue was undefined.

@jzunigax2 jzunigax2 added the bug Something isn't working label Aug 19, 2024
@jzunigax2 jzunigax2 self-assigned this Aug 19, 2024
@jzunigax2 jzunigax2 requested a review from sg-gs as a code owner August 19, 2024 22:17
Copy link

@sg-gs sg-gs merged commit e5fc5bd into master Aug 20, 2024
8 checks passed
@sg-gs sg-gs deleted the fix/shard-usecase-networkqueue branch August 20, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready-for-preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants