[_] feat: workspace role guard #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apsantiso
changed the title
apsantiso
force-pushed
the
feat/workspaces-permissions-middleware
branch
from
a655d5b to
1093314
Compare
apsantiso
force-pushed
the
feat/workspaces-permissions-middleware
branch
from
1093314 to
131525b
Compare
sg-gs
requested changes
Mar 18, 2024
| workspaceId: string, | ||
| role: WorkspaceRole, | ||
| ) { | ||
| const { workspace, workspaceUser } = |
There was a problem hiding this comment.
This destructuring could fail if the result from the database is null, could not?
There was a problem hiding this comment.
Either the workspace or the workspaceUser can be null. I handled that case in the usecase so a plain and not destructurable null is never returned.
sg-gs
approved these changes
Mar 19, 2024
|
apsantiso
added a commit
that referenced
this pull request
Jul 11, 2024
…dleware [_] feat: workspace role guard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.