Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PB-1551]: Feat/invite users to org #292

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

apsantiso
Copy link
Collaborator

@apsantiso apsantiso commented Mar 20, 2024

This PR is to enable workspace invitations to either new users and already registered users.

Mnemonic should come encrypted from the frontend with the public key of the precreated user or the registered email. Same pattern as we are using for sharing.

Invites should be only accepted if there is enough same left in the workspace. Once an invitation is sent, then that space counts as assigned.

As defined for the MVP, I set the limit to 10 users per workspace.

New Environment variables for sengrid templates:

#Workspaces
WORKSPACES_USER_INVITATION_EMAIL_ID=d-de1ed6df4a9947129c0bf592c808b58d
WORKSPACES_GUEST_USER_INVITATION_EMAIL_ID=d-41b4608fc94a41bca65aab7ed6ccad15

@apsantiso apsantiso changed the base branch from master to feat/workspaces-main March 20, 2024 14:25
@apsantiso apsantiso force-pushed the feat/invite-users-to-org branch from 75e87c1 to 0961943 Compare March 20, 2024 14:27
@apsantiso apsantiso self-assigned this Mar 20, 2024
@apsantiso apsantiso added the enhancement New feature or request label Mar 20, 2024
@apsantiso apsantiso requested a review from sg-gs March 21, 2024 12:54
@apsantiso apsantiso marked this pull request as ready for review March 21, 2024 12:54
.env.template Outdated Show resolved Hide resolved
src/modules/workspaces/workspaces.usecase.spec.ts Outdated Show resolved Hide resolved
src/modules/workspaces/workspaces.usecase.spec.ts Outdated Show resolved Hide resolved
src/modules/workspaces/workspaces.usecase.spec.ts Outdated Show resolved Hide resolved
@sg-gs
Copy link
Member

sg-gs commented Mar 21, 2024

To increase the coverage %, try to test at least on the repository the cases where a method should return 0 if the number being expected is null @apsantiso

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
78.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@apsantiso apsantiso requested a review from sg-gs April 5, 2024 14:32
@apsantiso apsantiso merged commit 0304f22 into feat/workspaces-main Apr 9, 2024
5 of 6 checks passed
@apsantiso apsantiso deleted the feat/invite-users-to-org branch May 9, 2024 16:08
apsantiso added a commit that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready-for-preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants