[PB-3189] fix: correctly remove children folders from lookup table on delete #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apsantiso
temporarily deployed
to
development
GitHub Actions
Inactive
…emoved folders correctly
apsantiso
force-pushed
the
fix/remove-deleted-children-folders-from-lookup-table
branch
from
7a0fb2c to
399917d
Compare
apsantiso
temporarily deployed
to
development
GitHub Actions
Inactive
|
apsantiso
changed the title
|
Migration run @apsantiso |
sg-gs
approved these changes
Dec 16, 2024
sg-gs
deleted the
fix/remove-deleted-children-folders-from-lookup-table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you delete a folder, its children folders are not being removed correctly from the lookup table, so searching was showing non accesible folders to the users.
This script just modifies 1 line of the function triggered to fix this behavior. For those who want to compare the changes: original migration here
Old condition:
ELSIF OLD.deleted = false AND NEW.removed = false AND (NEW.deleted = true OR NEW.removed = true) THENNew condition
ELSIF (OLD.deleted = false OR OLD.removed = false) AND (NEW.deleted = true OR NEW.removed = true) THENHow to Reproduce the Issue:
Permanently delete the Parent Folder from the trash.
Search for Child 1 or Child 2 using the search bar.
Expected Result:
Child 1 and Child 2 should not appear in the search results.
Actual Result:
Child 1 and Child 2 still appear in the search results.