Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ca 178 add score notion to compliance assessment #277

Merged
merged 61 commits into from
Apr 26, 2024

Conversation

Mohamed-Hacene
Copy link
Collaborator

No description provided.

@eric-intuitem
Copy link
Collaborator

Current version is very slow.

@ab-smith
Copy link
Contributor

Contributing to #193

None is not 0.0 (thought  bool(None) == bool(0.0))
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We could calculate intermediate aggregate scores on frontend side, but this is not mandatory for the first version.

@ab-smith ab-smith removed their request for review April 26, 2024 10:41
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-intuitem eric-intuitem merged commit 1f7328e into main Apr 26, 2024
14 checks passed
@eric-intuitem eric-intuitem deleted the CA-178-Add-score-notion-to-ComplianceAssessment branch April 26, 2024 17:50
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
@eric-intuitem eric-intuitem restored the CA-178-Add-score-notion-to-ComplianceAssessment branch April 26, 2024 21:32
@eric-intuitem eric-intuitem deleted the CA-178-Add-score-notion-to-ComplianceAssessment branch April 26, 2024 21:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scoring of requirements
4 participants