Workshop 1 #1130
Merged
Workshop 1 #1130
+1,078
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CA-672-Step-1.1-1.2
…CA-672-Step-1.1-1.2
…tion Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ant-community into CA-672-Step-1.1-1.2
…-ebios-models' into CA-672-Step-1.1-1.2
Mohamed-Hacene
requested review from
nas-tabchiche,
ab-smith and
eric-intuitem
backend/core/serializers.py
Outdated
Comment on lines
604
to
611
| ebios_rm_studies = serializers.SlugRelatedField( | ||
| many=True, | ||
| slug_field="id", | ||
| queryset=EbiosRMStudy.objects.all(), | ||
| required=False, | ||
| allow_null=True, | ||
| write_only=True, | ||
| ) |
There was a problem hiding this comment.
EBIOS RM stuff leaking on core should be avoided unless absolutely necessary. Since this field would only be needed in EBIOS RM contexts, what about having a serializer inheriting from this one in the ebios_rm app, with the additional field?
There was a problem hiding this comment.
Nevermind, let's take this shortcut.
nas-tabchiche
force-pushed
the
CA-674-Step-1.4
branch
from
c5360f7 to
8fd77a9
Compare
This allows to parse the value of a select option if it is a number
nas-tabchiche
force-pushed
the
CA-674-Step-1.4
branch
from
8fd77a9 to
4db984a
Compare
…community into CA-674-Step-1.4
nas-tabchiche
approved these changes
Dec 6, 2024
backend/core/serializers.py
Outdated
Comment on lines
604
to
611
| ebios_rm_studies = serializers.SlugRelatedField( | ||
| many=True, | ||
| slug_field="id", | ||
| queryset=EbiosRMStudy.objects.all(), | ||
| required=False, | ||
| allow_null=True, | ||
| write_only=True, | ||
| ) |
There was a problem hiding this comment.
Nevermind, let's take this shortcut.
There was a problem hiding this comment.
This route should be called baseline instead of base to reflect the naming used by the ANSSI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.