Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workshop 3 #1139

Merged
merged 26 commits into from
Dec 10, 2024
Merged

Workshop 3 #1139

merged 26 commits into from
Dec 10, 2024

Conversation

nas-tabchiche
Copy link
Contributor

No description provided.

@nas-tabchiche nas-tabchiche changed the title Ca 677 step 3 2 Workshop 3.2 Dec 5, 2024
@nas-tabchiche nas-tabchiche changed the title Workshop 3.2 Workshop 3 Dec 6, 2024
@nas-tabchiche nas-tabchiche marked this pull request as ready for review December 9, 2024 14:44
Mohamed-Hacene
Mohamed-Hacene reviewed Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@Mohamed-Hacene Mohamed-Hacene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged if my changes are 0k

frontend/src/lib/utils/crud.ts
Copy link
Collaborator

@Mohamed-Hacene Mohamed-Hacene Dec 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add in attack-paths and stakeholdes ebios_rm_study, folder foreignKeyFields for link in DetailedView.

@Mohamed-Hacene Mohamed-Hacene self-requested a review December 10, 2024 10:27
Mohamed-Hacene
Mohamed-Hacene approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@Mohamed-Hacene Mohamed-Hacene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0k

@nas-tabchiche nas-tabchiche merged commit 020b34a into main Dec 10, 2024
20 checks passed
@nas-tabchiche nas-tabchiche deleted the CA-677-step-3-2 branch December 10, 2024 10:57
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Mohamed-Hacene Mohamed-Hacene Mohamed-Hacene approved these changes

@ab-smith ab-smith Awaiting requested review from ab-smith

@eric-intuitem eric-intuitem Awaiting requested review from eric-intuitem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nas-tabchiche @Mohamed-Hacene