Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailed ANSSI hygiene guide #1152

Merged
merged 5 commits into from
Dec 8, 2024
Merged

Detailed ANSSI hygiene guide #1152

merged 5 commits into from
Dec 8, 2024

Conversation

eric-intuitem
Copy link
Collaborator

Create anssi-guide-hygiene-detail.xlsx
Add procedure category
update doc-pol
update convert_library

@eric-intuitem eric-intuitem force-pushed the improve/guide-hygiene-detail branch 2 times, most recently from d6c3262 to a591001 Compare December 8, 2024 02:39
Create anssi-guide-hygiene-detail.xlsx
Add procedure category
update doc-pol
update convert_library
@eric-intuitem eric-intuitem force-pushed the improve/guide-hygiene-detail branch from a591001 to 4473dea Compare December 8, 2024 02:40
Copy link
Contributor

@ab-smith ab-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's odd to have other files that are not related to the framework on this PR

@eric-intuitem eric-intuitem force-pushed the improve/guide-hygiene-detail branch from b6bdd65 to 8bd425b Compare December 8, 2024 16:57
use bullet point to avoid ambiguity
improve urn when ref_id missing
Use the urn of parent + counter
Update test-data.ts
rename doc-pol
fix depth
@eric-intuitem eric-intuitem force-pushed the improve/guide-hygiene-detail branch from 8bd425b to f79e057 Compare December 8, 2024 17:16
@eric-intuitem eric-intuitem force-pushed the improve/guide-hygiene-detail branch from a7c87d4 to 3a5a247 Compare December 8, 2024 18:49
@eric-intuitem
Copy link
Collaborator Author

The changes are necessary to add the procedure category, which is used in the revamped version of usual controls library (ex poldoc).
Another change relates to the generation of URNs by convert_library.py, to improve readability and maintainability of the new library and all future ones.

@eric-intuitem eric-intuitem marked this pull request as ready for review December 8, 2024 20:09
@ab-smith ab-smith self-requested a review December 8, 2024 20:56
Copy link
Contributor

@ab-smith ab-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional ok, we need to mention the required doc pol upgrade as well as the how to on gitbook

@ab-smith ab-smith merged commit 063d3f9 into main Dec 8, 2024
19 checks passed
@ab-smith ab-smith deleted the improve/guide-hygiene-detail branch December 8, 2024 21:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants