Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project restructure and automated testing #13

Open
matthijs166 opened this issue Aug 3, 2022 · 2 comments
Open

Project restructure and automated testing #13

matthijs166 opened this issue Aug 3, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@matthijs166
Copy link
Contributor

I think the project can improve a lot if we restructure some files to make the source code more readable. And add some automated testing into the project for quality insurance

@invakid404 invakid404 added the enhancement New feature or request label Aug 3, 2022
@invakid404
Copy link
Owner

There's room for improvement here for sure. I've hacked this entire project in a single sitting and I definitely didn't write it with testability in mind :D

Any suggestions and PRs are welcome. I'll think about ways to improve things in the near future as well.

@invakid404
Copy link
Owner

I've been thinking about this again, I'm thinking of incorporating some integration tests, i.e. spinning up a sample Payload project and running some tests via the API (e.g. uploading an image, verifying that Blurhash is computed). This should also help catch any incompatibilities with new Payload versions that might occur in the future.

Unit testing wouldn't bring much value, as all this plugin does is glue together a few libs, so if anything, I'd be testing that third-party libs behave the way I'd expect them. Integration tests would be pretty useful though, I'll look into arranging that in the near future.

@invakid404 invakid404 self-assigned this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants