-
-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Supplier part pack size #3644
Feature: Supplier part pack size #3644
Conversation
- Need to use custom filter class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Am I right that the new field is only as a data point but without buisne3ss logic for splitting?
There will have to be some business logic added. Thinking about it, it becomes quite complex but should be attainable. For example, (and the use case I am trying to implement specifically for) say you have a part "thermal adhesive" which your units are "cc". You can buy it from one supplier in a tube of 30cc, and another in a tub of 500cc. The supplierpart quantity is "1" in each case, but the amount of "part" you are getting is markedly different. So there needs to be logic in place to convert the incoming stock quantity from "supplier part units" to "part units". And then update every place where the "on order" quantity is reported to take this new pack quantity into account... |
@SchrodingersGat sounds a lot like #1435 |
- May god have mercy on my soul
… working as expected
- Check in existing unit test also
- Previous unit test was actually in error - Logic for calculating "on_order" was broked
@SchrodingersGat Cool new feature! I have tested it using the UI and it looks good on my side. |
The terminology should cover the following cases (and probably additional ones also)
|
This is nice -- can you add this as a context variable to reports? Would be nice to show total quantity and total packs/sets on purchase orders. |
@derekwolfson the PR is merged half a year. Please open new feature requests for new requests. |
Adds the concept of "pack size" for the supplier part
Closes #1435
TODO
on_order
quantity (must include calculation of pack_size)