From ed254b1d77d1aab14f25a2c7f8fa4151a43bfa69 Mon Sep 17 00:00:00 2001 From: James Monger Date: Wed, 13 Sep 2023 20:19:54 +0100 Subject: [PATCH 1/3] ci: run ci against node `18.x, 20.x` (#1527) * ci: run ci against node `16.x, 18.x, 20.x` fixes #1526 * Update ci.yml --------- Co-authored-by: Podaru Dragos --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 20bed2f6d..1bc5aa2ab 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -26,7 +26,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: [10.x, 12.x, 14.x, 15.x] + node-version: [18.x, 20.x] ts-project: [src/tsconfig.json, src/tsconfig-es6.json] env: TS_NODE_PROJECT: ${{ matrix.ts-project }} @@ -55,7 +55,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node-version: [10.x, 12.x, 14.x, 15.x, 16.x] + node-version: [18.x, 20.x] ts-project: [src/tsconfig.json, src/tsconfig-es6.json] env: TS_NODE_PROJECT: ${{ matrix.ts-project }} @@ -91,4 +91,4 @@ jobs: uses: codecov/codecov-action@f32b3a3741e1053eb607407145bc9619351dc93b # renovate: tag=v2 with: directory: coverage/ - fail_ci_if_error: true \ No newline at end of file + fail_ci_if_error: true From 0c800ffb85ed07d94bc5f373f3281cf754c385b5 Mon Sep 17 00:00:00 2001 From: Podaru Dragos Date: Wed, 13 Sep 2023 22:26:09 +0300 Subject: [PATCH 2/3] update ci (#1532) --- .github/workflows/ci.yml | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1bc5aa2ab..3ca10fe33 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,7 +14,7 @@ jobs: - uses: nuget/setup-nuget@v1 - uses: actions/setup-node@v1 with: - node-version: 16 + node-version: 18 - run: npm install - run: nuget install Selenium.WebDriver.IEDriver -Version 4.0.0.1 - run: npm run test:browser @@ -61,17 +61,17 @@ jobs: TS_NODE_PROJECT: ${{ matrix.ts-project }} steps: - - name: Checkout Project - uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 # renovate: tag=v2 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 # renovate: tag=v2 - with: - node-version: ${{ matrix.node-version }} - cache: npm - registry-url: https://registry.npmjs.org/ - - run: npm cache clean --force - - run: npm ci - - run: npm run build --if-present + - name: Checkout Project + uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 # renovate: tag=v2 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 # renovate: tag=v2 + with: + node-version: ${{ matrix.node-version }} + cache: npm + registry-url: https://registry.npmjs.org/ + - run: npm cache clean --force + - run: npm ci + - run: npm run build --if-present Upload_Coverage_Report: name: Upload coverage report to codecov @@ -91,4 +91,4 @@ jobs: uses: codecov/codecov-action@f32b3a3741e1053eb607407145bc9619351dc93b # renovate: tag=v2 with: directory: coverage/ - fail_ci_if_error: true + fail_ci_if_error: true \ No newline at end of file From d78964749abfa9df6abd47181a3e16e6d2927a23 Mon Sep 17 00:00:00 2001 From: Dan Cavanagh Date: Wed, 13 Sep 2023 15:42:08 -0400 Subject: [PATCH 3/3] Fix CI (#1520) Co-authored-by: Podaru Dragos Co-authored-by: James Monger --- .github/workflows/ci.yml | 40 ++++++++++++++++++++-------------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3ca10fe33..eae8ec506 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,9 +10,9 @@ jobs: browser: runs-on: windows-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: nuget/setup-nuget@v1 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v3 with: node-version: 18 - run: npm install @@ -33,9 +33,9 @@ jobs: steps: - name: Checkout Project - uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 # renovate: tag=v2 + uses: actions/checkout@v3 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 # renovate: tag=v2 + uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} cache: npm @@ -45,7 +45,7 @@ jobs: - name: Run tests run: npm test --coverage - name: Store code coverage report - uses: actions/upload-artifact@82c141cc518b40d92cc801eee768e7aafc9c2fa2 # renovate: tag=v2 + uses: actions/upload-artifact@v3 with: name: coverage path: coverage/ @@ -61,17 +61,17 @@ jobs: TS_NODE_PROJECT: ${{ matrix.ts-project }} steps: - - name: Checkout Project - uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 # renovate: tag=v2 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 # renovate: tag=v2 - with: - node-version: ${{ matrix.node-version }} - cache: npm - registry-url: https://registry.npmjs.org/ - - run: npm cache clean --force - - run: npm ci - - run: npm run build --if-present + - name: Checkout Project + uses: actions/checkout@v3 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v3 + with: + node-version: ${{ matrix.node-version }} + cache: npm + registry-url: https://registry.npmjs.org/ + - run: npm cache clean --force + - run: npm ci + - run: npm run build --if-present Upload_Coverage_Report: name: Upload coverage report to codecov @@ -79,16 +79,16 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout Project - uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 # renovate: tag=v2 + uses: actions/checkout@v3 with: fetch-depth: 2 - name: Download Coverage report - uses: actions/download-artifact@f023be2c48cc18debc3bacd34cb396e0295e2869 # renovate: tag=v2 + uses: actions/download-artifact@v3 with: name: coverage path: coverage/ - name: Codecov Upload - uses: codecov/codecov-action@f32b3a3741e1053eb607407145bc9619351dc93b # renovate: tag=v2 + uses: codecov/codecov-action@v3 with: directory: coverage/ - fail_ci_if_error: true \ No newline at end of file + fail_ci_if_error: true