From 82bb1bbd544f87fb4cee06d1574a0481029f8baa Mon Sep 17 00:00:00 2001 From: AkshayJangid <16ucc103@lnmiit.ac.in> Date: Wed, 1 Nov 2023 00:45:18 +0530 Subject: [PATCH 1/2] Update README.md by going through the documentation , it is not where hinted that we need to place it in separate file. Thus explicitly mentioning it in readme. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 9075b577b..ed0859ff9 100644 --- a/README.md +++ b/README.md @@ -125,7 +125,7 @@ export interface ThrowableWeapon { ``` InversifyJS needs to use the type as identifiers at runtime. We use symbols as identifiers but you can also use classes and or string literals. - +PLEASE MAKE SURE TO PLACE THIS TYPES DECLARATION IN A SEPARATE FILE. ```ts // file types.ts From ba0da86c0849d99da589ef5ae6c24073f9d2b144 Mon Sep 17 00:00:00 2001 From: James Monger Date: Thu, 2 Nov 2023 09:51:17 +0000 Subject: [PATCH 2/2] Update README.md add link to bug --- README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index ed0859ff9..df70c8088 100644 --- a/README.md +++ b/README.md @@ -125,7 +125,9 @@ export interface ThrowableWeapon { ``` InversifyJS needs to use the type as identifiers at runtime. We use symbols as identifiers but you can also use classes and or string literals. -PLEASE MAKE SURE TO PLACE THIS TYPES DECLARATION IN A SEPARATE FILE. + +PLEASE MAKE SURE TO PLACE THIS TYPES DECLARATION IN A SEPARATE FILE. (see bug #1455) + ```ts // file types.ts