Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract plan metadata interface #1673

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Extract plan metadata interface #1673

merged 3 commits into from
Dec 4, 2024

Conversation

notaphplover
Copy link
Member

Description

  • Added PlanMetadata internal interface.
  • Updated interfaces.NextArgs with isOptional.

Related Issue

#566

Motivation and Context

This PR updates the planning algorithm in a way it can be requested optional activations in the root level of the plan.

How Has This Been Tested?

  • Test passes successfully.

Types of changes

  • Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the changelog.

@notaphplover notaphplover self-assigned this Dec 4, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.95%. Comparing base (b391465) to head (e38e7bc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/container/container.ts 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1673      +/-   ##
==========================================
- Coverage   99.09%   98.95%   -0.15%     
==========================================
  Files          52       52              
  Lines        1333     1343      +10     
  Branches      181      184       +3     
==========================================
+ Hits         1321     1329       +8     
- Misses         11       13       +2     
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notaphplover notaphplover marked this pull request as ready for review December 4, 2024 21:02
@notaphplover notaphplover merged commit fdbf854 into master Dec 4, 2024
4 of 6 checks passed
@notaphplover notaphplover deleted the feat/extract-plan-metadata-interface branch December 4, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notaphplover notaphplover

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@notaphplover