Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: bump SDK version > 3.1.0 #605

Closed
1 task done
sebastianbuechler opened this issue Nov 27, 2023 · 6 comments
Closed
1 task done

request: bump SDK version > 3.1.0 #605

sebastianbuechler opened this issue Nov 27, 2023 · 6 comments
Labels
feature request Needs: Triage The issue needs triaging

Comments

@sebastianbuechler
Copy link

Is there an existing feature request for this?

  • I have searched the existing issues.

Command

No response

Description

When using the latest version of the lint package melos is incompatible:

Because my_workspace depends on lint >=2.2.0 which requires SDK version >=3.1.0 <4.0.0, version solving failed.

Reasoning

Keeping dependencies up to date.

Additional context and comments

No response

@spydon
Copy link
Collaborator

spydon commented Dec 4, 2023

The lint package should preferably be depended on a package level, not in the root pubspec.yaml.

packages/
|__ your_package/
   |__ pubspec.yaml <-- in here
pubspec.yaml <-- Only melos version and sdk version

@spydon
Copy link
Collaborator

spydon commented Dec 15, 2023

@sebastianbuechler here is a good example of how the directory structure can look like to not have a package/app in the root:
#616 (comment)

I'll close this meanwhile since Melos doesn't really support having a package or app at the root of the monorepo.

@spydon spydon closed this as completed Dec 15, 2023
@sebastianbuechler
Copy link
Author

@spydon I don't have an app in root but specify the workspace there with a melos config file. The issue still persists.

@spydon
Copy link
Collaborator

spydon commented Dec 15, 2023

@spydon I don't have an app in root but specify the workspace there with a melos config file. The issue still persists.

Can you post your root pubspec?

@sebastianbuechler
Copy link
Author

@spydon I don't have an app in root but specify the workspace there with a melos config file. The issue still persists.

Can you post your root pubspec?

Sorry for the late reply. Here it is:

name: company_workspace

environment:
  sdk: '>=3.0.0 <4.0.0'
dev_dependencies:
  melos: ^4.0.0
  lint: ^2.1.2

@spydon
Copy link
Collaborator

spydon commented Jan 30, 2024

@sebastianbuechler the lint package shouldn't be in there, it should be in the packages pubspec files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Needs: Triage The issue needs triaging
Projects
None yet
Development

No branches or pull requests

2 participants