Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through payment_intent_data #641

Open
evancaldwell opened this issue Nov 7, 2024 · 1 comment
Open

Pass through payment_intent_data #641

evancaldwell opened this issue Nov 7, 2024 · 1 comment

Comments

@evancaldwell
Copy link

evancaldwell commented Nov 7, 2024

Feature request

  • Extension name: firestore-stripe-payments

Is your feature request related to a problem? Please describe.

I need to make destination payments as a platform on Stripe. This is done by adding payment_intent_data to the checkoutSession but this extension doesn't pass that data through when creating the checkoutSession

Describe the solution you'd like

Simply pulling payment_intent_data from the snap and adding it to the sessionCreateParams with a check similar to what's already being done for line_items should be enough.

Describe alternatives you've considered

For me the only other solution would be to not use this extension.

Additional context

I saw an old issue about supporting Stripe Connect which was closed. Although this destination payments are part of Stripe Connect I don't think there is a need to support everything, just adding payment_intent_data would bring in some extra functionality. I've tested this by editing the function instance in my Google Cloud and it is working.
I submitted the following PR for this feature request: #642

@evancaldwell
Copy link
Author

Anyone have a chance to look at this? It's really small change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant