Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POWER<x> data-point is defined as boolean but should be string #277

Open
Sineos opened this issue Aug 27, 2022 · 1 comment
Open

POWER<x> data-point is defined as boolean but should be string #277

Sineos opened this issue Aug 27, 2022 · 1 comment

Comments

@Sineos
Copy link

Sineos commented Aug 27, 2022

Describe the bug
According to the Tasmota documentation the POWER accepts more than just boolean values:

grafik

With the current boolean definition, sending e.g. TOGGLE is not possible

Expected behavior
Accept string

Versions:

  • Adapter version: 2.5.1

Additional context
I modified https://github.com/ioBroker/ioBroker.sonoff/blob/master/lib/datapoints.js to

POWER1:        {type: 'string', role: 'switch',                   read: true, write: true,  storeMap: true},

If acceptable I can launch a PR to modify the POWER Definitions to string

@Apollon77
Copy link
Collaborator

Note: In fact this would be a breaking change, because then also the role do not mtch anymore ... someone needs to look deeper into that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants