Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue that last image is never shown in image8 widget #377

Merged
merged 2 commits into from
Feb 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,14 @@ body:
validations:
required: true

- type: textarea
attributes:
label: Page or affected widget
render: shell
description: If applicable, add an export of the affected widget or page.
validations:
required: false

- type: input
attributes:
label: Adapter version
Expand Down
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,9 @@ E.g., if it was used in a menu and the menu is red, the circle would be red.
### **WORK IN PROGRESS**
-->
## Changelog
### **WORK IN PROGRESS**
* (foxriver76) fixed issue that last image is never shown in image8 widget

### 2.9.32 (2024-02-16)
* (foxriver76) implemented buttons to show or hide all views in views manager
* (foxriver76) fixed issue with signals on RxWidgets
Expand Down
2 changes: 1 addition & 1 deletion src/src/Vis/Widgets/Basic/BasicImage8.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export default class BasicImage8 extends VisRxWidget<RxData> {

const srcArr: string[] = [];

for (let i = 0; i < this.state.rxData.count; i++) {
for (let i = 0; i <= this.state.rxData.count; i++) {
// @ts-expect-error check this
if (this.state.rxData[`src_${i}`]) {
// @ts-expect-error check this
Expand Down
Loading