From 27fb7b2fa29e7fd3a4a85d96e4cbafe5a3345f25 Mon Sep 17 00:00:00 2001 From: foxriver76 Date: Tue, 20 Feb 2024 08:36:35 +0100 Subject: [PATCH 1/3] fixed issue that last image is never shown in image8 widget - closes #376 --- README.md | 3 +++ src/src/Vis/Widgets/Basic/BasicImage8.tsx | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index e30dcfc6..532ccae3 100644 --- a/README.md +++ b/README.md @@ -263,6 +263,9 @@ E.g., if it was used in a menu and the menu is red, the circle would be red. ### **WORK IN PROGRESS** --> ## Changelog +### **WORK IN PROGRESS** +* (foxriver76) fixed issue that last image is never shown in image8 widget + ### 2.9.32 (2024-02-16) * (foxriver76) implemented buttons to show or hide all views in views manager * (foxriver76) fixed issue with signals on RxWidgets diff --git a/src/src/Vis/Widgets/Basic/BasicImage8.tsx b/src/src/Vis/Widgets/Basic/BasicImage8.tsx index c80691d0..a5682974 100644 --- a/src/src/Vis/Widgets/Basic/BasicImage8.tsx +++ b/src/src/Vis/Widgets/Basic/BasicImage8.tsx @@ -77,7 +77,7 @@ export default class BasicImage8 extends VisRxWidget { const srcArr: string[] = []; - for (let i = 0; i < this.state.rxData.count; i++) { + for (let i = 0; i <= this.state.rxData.count; i++) { // @ts-expect-error check this if (this.state.rxData[`src_${i}`]) { // @ts-expect-error check this From 4fa0495f6ffd51d195a3e7309d8417a5e23ce0b6 Mon Sep 17 00:00:00 2001 From: foxriver76 Date: Tue, 20 Feb 2024 08:46:02 +0100 Subject: [PATCH 2/3] issue template extended --- .github/ISSUE_TEMPLATE/bug_report.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 0242ba97..27fdf6cb 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -52,6 +52,14 @@ body: validations: required: true + - type: textarea + attributes: + label: Page or affected widget + render: shell + description: If applicable, add an export of the affected widget or page. + validations: + required: false + - type: input attributes: label: Adapter version From 1ae56a3d5de72104d4616a088b09b9c6be2e5729 Mon Sep 17 00:00:00 2001 From: foxriver76 Date: Wed, 21 Feb 2024 08:31:08 +0100 Subject: [PATCH 3/3] make it possible to click through signal image if in front of widget -closes #375 --- README.md | 1 + src/src/Vis/visRxWidget.tsx | 2 ++ 2 files changed, 3 insertions(+) diff --git a/README.md b/README.md index 532ccae3..ddeb846a 100644 --- a/README.md +++ b/README.md @@ -265,6 +265,7 @@ E.g., if it was used in a menu and the menu is red, the circle would be red. ## Changelog ### **WORK IN PROGRESS** * (foxriver76) fixed issue that last image is never shown in image8 widget +* (foxriver76) make it possible to click through signal image if in front of widget ### 2.9.32 (2024-02-16) * (foxriver76) implemented buttons to show or hide all views in views manager diff --git a/src/src/Vis/visRxWidget.tsx b/src/src/Vis/visRxWidget.tsx index f01be2bd..4560c0d1 100644 --- a/src/src/Vis/visRxWidget.tsx +++ b/src/src/Vis/visRxWidget.tsx @@ -802,6 +802,8 @@ class VisRxWidget> extends VisBaseWidget { left: `${parseInt(this.state.rxData[`signals-horz-${index}`], 10) || 0}%`, zIndex: 10, textAlign: 'center', + // make it possible to click through signal if in front of widget + pointerEvents: 'none', }; if (icon) { const imageStyle = {