Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects do not seem to be recracked on file changes #105

Open
baronfel opened this issue Apr 12, 2021 · 4 comments
Open

Projects do not seem to be recracked on file changes #105

baronfel opened this issue Apr 12, 2021 · 4 comments
Labels

Comments

@baronfel
Copy link
Collaborator

Describe the bug
User @purkhusid on the FSSF slack reported that their projects don't seem to reload after adding a PackageReference element to the project. We should triage this.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behaviour
The project should be cracked, the new reference should be added, and the ProjectController should be notified of the change.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • OS:
  • Ionide version:
  • VSCode version:
  • dotnet SDK version:
  • mono / .Net Framework version:

Additional context
Add any other context about the problem here.

@baronfel baronfel changed the title Projects do not seem to be recracked ok file changes Projects do not seem to be recracked on file changes Apr 12, 2021
@baronfel
Copy link
Collaborator Author

Context:

Is there any flag that helps with having to reload VS Code every time I add a new NuGet packages to .fsproj ?
View in Slack

@purkhusid
Copy link

@baronfel I tested various combinations and the winning combination to get things working was:

  1. Add PackageReference to .fsproj
  2. dotnet restore
  3. Make a change to .fs file and save

My workflow was usually in this order:

  1. Add PackageReference to .fsproj
  2. Make a change to .fs file and save
  3. dotnet restore or dotnet build

Feel free to close the issue if you don't think this is worth checking out!

@baronfel
Copy link
Collaborator Author

That sorta feels to me like we're not triggering a re-parse-and-check of the files in a project when the project is updated.

@TheAngryByrd
Copy link
Member

I do have a better project reload in FSAC Adaptive Server now, should I move that code to here or possibly remove the functionality from here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants