Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type load exceptions from the bound msbuild libraries can escape being caught and handled by the failure loop #113

Open
baronfel opened this issue Aug 18, 2021 · 1 comment

Comments

@baronfel
Copy link
Collaborator

Describe the bug

If there's a mismatch in the msbuild dlls, then a typeloadexception will escape the error handling present in the library.

The first time the libraries are loaded are on calls to this function. This call happens here. Therefore, we should catch exceptions here and bubble that up as a Result.Error so that the error can be reported by the notification event handler as we expect, instead of being uncaught and never notifying callers.

@TheAngryByrd
Copy link
Member

@baronfel think this is still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants