Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-sdk-go close() #36

Open
manishiitg opened this issue May 24, 2021 · 1 comment
Open

ion-sdk-go close() #36

manishiitg opened this issue May 24, 2021 · 1 comment

Comments

@manishiitg
Copy link

Your environment.

  • Version: Release or SHA
  • Browser: include version
  • Other Information - stacktraces, related issues, suggestions how to fix, links for us to have context

What did you do?

when i call Close(), it doesn't really disconnection the session from ion-sfu? the session remains still active. Close session is not called on ion-sfu. is this a bug or i am doing something wrong?

What did you expect?

What happened?

@manishiitg
Copy link
Author

there is a major issue here to lock getting stuck

https://github.com/pion/ion-sdk-go/blob/master/engine.go#L65 DelClient internally calls c.Close()
and c.Close() will call e.DelClient
https://github.com/pion/ion-sdk-go/blob/26d31be8c6027b86740a34f12838c053b1270abd/client.go#L270

but it doesn't release the lock so the code gets stuck waiting for lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant