Skip to content
This repository has been archived by the owner on Sep 6, 2024. It is now read-only.

getBalances will no longer require a threshold #463

Closed
JakeSCahill opened this issue Feb 27, 2020 · 1 comment
Closed

getBalances will no longer require a threshold #463

JakeSCahill opened this issue Feb 27, 2020 · 1 comment
Labels
L - Has PR Lifecycle - Somebody has created a Pull Request about it P2 - High Priority - Prefer to fix or merge this

Comments

@JakeSCahill
Copy link
Contributor

JakeSCahill commented Feb 27, 2020 •
edited
Loading

Bug description

In this PR, the threshold parameter is removed from the getBalances endpoint on IRI nodes.

Currently, this is a required parameter is the library, so we should make it optional.

Expected behaviour

The threshold parameter is optional (for backwards compatibility)

Actual behavior

The threshold parameter is required

Am I planning to do it myself with a PR?

No.
@laumair laumair mentioned this issue Jun 14, 2020
Merged
@laumair laumair added C - core L - Has PR Lifecycle - Somebody has created a Pull Request about it P2 - High Priority - Prefer to fix or merge this labels Jun 14, 2020
@laumair
Copy link
Contributor

laumair commented Jun 18, 2020

Fixed in #481

@laumair laumair closed this as completed Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
L - Has PR Lifecycle - Somebody has created a Pull Request about it P2 - High Priority - Prefer to fix or merge this
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@laumair @JakeSCahill