Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Support DNSLink on ENS (move namesys defaults out of Kubo) #60

Closed
lidel opened this issue Mar 7, 2023 · 4 comments · Fixed by #57
Closed

Support DNSLink on ENS (move namesys defaults out of Kubo) #60

lidel opened this issue Mar 7, 2023 · 4 comments · Fixed by #57
Assignees
Labels
bug Something isn't working

Comments

@lidel
Copy link
Collaborator

lidel commented Mar 7, 2023

Problem

bifrost-gateway must have feature and behavior parity with Kubo, but we have a bug around ENS:

Potential cause

Seems that we are running different namesys config than Kubo.

It should use the same set of defaultResolvers to support ENS and UD, as noted in the config docs, but *.eth resolution does not work atm.

Cleanup proposal

Move defaultResolvers to one of upstream libraries, and make them implicit default to avoid ENS failures like this one.

Option A: move to go-namesys (global)

This applies defaults to both DNSLinks and Multiaddrs, allowing use of *.eth in /dnsaddr too

Option B: move to go-libipfs/gateway (minimal, scoped to DNSLinks)

This would only apply to DNSLinks, but that is enough given the utility of ENS today (just DNSLinks).


@hacdias @aschmahmann Thoughts?

I feel (B) may be cleaner:

  • WithNameSystem allows users to pass custom resolvers
  • if no WithNameSystem is passed we apply defaultResolvers on the library level as implicit default
@lidel lidel added the bug Something isn't working label Mar 7, 2023
@lidel lidel moved this to 📋 Backlog in bifrost-gateway Mar 7, 2023
@lidel lidel changed the title Support DNSLink on *.eth: use the same implicit DNS resolvers as Kubo Support DNSLink on ENS AKA decouple namesys defaults from Kubo Mar 7, 2023
@lidel lidel changed the title Support DNSLink on ENS AKA decouple namesys defaults from Kubo Support DNSLink on ENS (decouple namesys defaults from Kubo) Mar 7, 2023
@lidel lidel changed the title Support DNSLink on ENS (decouple namesys defaults from Kubo) Support DNSLink on ENS (move namesys defaults out of Kubo) Mar 7, 2023
@hacdias
Copy link
Collaborator

hacdias commented Mar 8, 2023

@lidel I think the idea of moving to go-libipfs/gateway (approach B) is the best option to go, as it allows re-use without cluttering too much our other general packages (go-namesys).

@lidel
Copy link
Collaborator Author

lidel commented Mar 9, 2023

@hacdias sgtm. do you prefer to do it as part of ipfs/kubo#9681 after?

@hacdias
Copy link
Collaborator

hacdias commented Mar 10, 2023

I think after would be better.

@hacdias hacdias self-assigned this Mar 10, 2023
@hacdias hacdias moved this to 🥞 Todo in IPFS Shipyard Team Mar 10, 2023
@hacdias hacdias moved this from 🥞 Todo to 🛑 Blocked in IPFS Shipyard Team Mar 10, 2023
@hacdias
Copy link
Collaborator

hacdias commented Mar 14, 2023

@lidel I decided doing it during.

@hacdias hacdias moved this from 🛑 Blocked to 🏃‍♀️ In Progress in IPFS Shipyard Team Mar 14, 2023
@hacdias hacdias moved this from 📋 Backlog to 🏗 In progress in bifrost-gateway Mar 14, 2023
@lidel lidel closed this as completed in #57 Mar 29, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in bifrost-gateway Mar 29, 2023
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In Progress to 🎉 Done in IPFS Shipyard Team Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants