Skip to content

Commit

Permalink
chore: cosmetics
Browse files Browse the repository at this point in the history
  • Loading branch information
lidel committed Oct 17, 2023
1 parent c7ca873 commit 3501551
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ The following emojis are used to highlight certain changes:
* `namesys/resolver.ResolveIPNS` has been moved to `namesys.ResolveIPNS` and now returns a TTL
in addition to the resolved path.
*`boxo/ipns` record defaults follow recommendations from [IPNS Record Specification](https://specs.ipfs.tech/ipns/ipns-record/#ipns-record):
* `DefaultRecordTTL` is now set to 1h
* `DefaultRecordLifetime` now match the expiration window of Amino DHT and is set to 48h
* `DefaultRecordTTL` is now set to `1h`
* `DefaultRecordLifetime` follows the increased expiration window of Amino DHT ([go-libp2p-kad-dht#793](https://github.com/libp2p/go-libp2p-kad-dht/pull/793)) and is set to `48h`
* 🛠 The `gateway`'s `IPFSBackend.ResolveMutable` is now expected to return a TTL in addition to
the resolved path. If the TTL is unknown, 0 should be returned.

Expand Down
4 changes: 2 additions & 2 deletions namesys/dns_resolver.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func (r *DNSResolver) resolveOnceAsync(ctx context.Context, p path.Path, options

out := make(chan ResolveAsyncResult, 1)
if p.Namespace() != path.IPNSNamespace {
out <- ResolveAsyncResult{Err: fmt.Errorf("unsupported namespace: %s", p.Namespace())}
out <- ResolveAsyncResult{Err: fmt.Errorf("unsupported namespace: %q", p.Namespace())}
close(out)
return out
}
Expand All @@ -63,7 +63,7 @@ func (r *DNSResolver) resolveOnceAsync(ctx context.Context, p path.Path, options
return out
}

log.Debugf("DNSResolver resolving %s", fqdn)
log.Debugf("DNSResolver resolving %q", fqdn)

if !strings.HasSuffix(fqdn, ".") {
fqdn += "."
Expand Down
2 changes: 1 addition & 1 deletion namesys/interface.go
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ type PublishOptions struct {
// EOL defines for how long the published value is valid.
EOL time.Time

// TTL defines for how long the published value is valid.
// TTL defines for how long the published value is cached locally before checking for updates.
TTL time.Duration

// IPNSOptions are options passed by [IPNSPublisher] to [ipns.NewRecord] when
Expand Down

0 comments on commit 3501551

Please sign in to comment.