-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the red workflows from CI #147
Comments
Agreed, thanks for opening this! These should solve themselves:
"Test Kubo (e2e)" deserves some work, a proposal: This way we can strike a balance between "I changed a predicate, Kubo doesn't pass half of the test suite now, let's not be silent about it" and "Kubo is missing a patch, the test suite is failing as expected, let's not output RED status in CI" like this case #131 (comment)
|
We worked around most of the red CI, but before we close this, |
We're running a lot of different workflows on PRs to this repo now. I find it extremely confusing to have red runs on PRs. Also, I think it promotes the expectation that it's OK for CI on PRs to be red.
If we expect and want to keep expecting a failure of some workflow, I think we should catch such failure in the workflow and report workflow success on that failure, and workflow failure otherwise. This would send a clear signal to the contributors: 🟢 - the workflow reached an expected result (be it success or failure), 🔴 - the workflow reached an unexpected result (you have to look into it).
cc @laurentsenta
The text was updated successfully, but these errors were encountered: