You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A CORS request is an HTTP request that includes an Origin header. It cannot be reliably identified as participating in the CORS protocol as the Origin header is also included for all requests whose method is neither GET nor HEAD.
There is no Origin header in the request, so this is not a CORS request.
Why does the test expect CORS headers in the response?
The text was updated successfully, but these errors were encountered:
I would say also, the GET test expects the following headers to be present in the response:
Access-Control-Allow-Origin
Access-Control-Allow-Methods
Access-Control-Allow-Headers
Access-Control-Expose-Headers
Of these only Access-Control-Allow-Origin is valid in the response to a CORS request, the others are for a CORS-preflight request (e.g. OPTIONS, not GET) so I don't think this test is valid. Ref - https://fetch.spec.whatwg.org/#http-responses
Is it just asserting on the behaviour of the go-HTTP server? There's no mention of CORS in any of the HTTP Gateway specs so it's unclear what's intended to happen here.
achingbrain
added a commit
to ipfs/helia-http-gateway
that referenced
this issue
Jul 9, 2024
Skips practically all of them to just get the framework in place.
I'm not sure all the tests are valid, the spec is missing large
chunks of functionality asserted in the tests, but the assertions
don't necessarily assert IETF/W3c spec compliant behaviour, for
example: ipfs/gateway-conformance#217
Skips practically all of them to just get the framework in place.
I'm not sure all the tests are valid, the spec is missing large
chunks of functionality asserted in the tests, but the assertions
don't necessarily assert IETF/W3c spec compliant behaviour, for
example: ipfs/gateway-conformance#217
There's a test:
It makes a GET request to
"/ipfs/{{CID}}/"
and expectsAccess-Control-Allow-Origin
etc in the response.The test sends:
The fetch spec says:
There is no
Origin
header in the request, so this is not a CORS request.Why does the test expect CORS headers in the response?
The text was updated successfully, but these errors were encountered: