Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for HTTP 302 /ipns/{legacy-peerid} → /ipns/{cidv1-libp2p-key-base36} #38

Closed
lidel opened this issue Apr 12, 2023 · 0 comments · Fixed by #136
Closed

Add test for HTTP 302 /ipns/{legacy-peerid} → /ipns/{cidv1-libp2p-key-base36} #38

lidel opened this issue Apr 12, 2023 · 0 comments · Fixed by #136
Assignees
@hacdias
Labels
test:coverage Improves the spec covered by this test suite

Comments

@lidel
Copy link
Member

lidel commented Apr 12, 2023 •
edited
Loading

Ref. https://github.com/ipfs/boxo/pull/236/files#diff-d34c7069ce5e81d45082b19eb3e869ee1a086e185dcd6630e75e3ed0d368b546

This is not part of specs (but we could add this to https://specs.ipfs.tech/http-gateways/path-gateway/#appendix-notes-for-implementers), just a quality-of-life improvement we've introduced in ipfs/kubo#9785 to support non-CIDv1, legacy peerids (RSA / ed25519) encoded as Multihash in Base58 in a way that redirects user to a canonical URL.
@laurentsenta laurentsenta added the test:coverage Improves the spec covered by this test suite label Jun 26, 2023
@hacdias hacdias self-assigned this Aug 9, 2023
@hacdias hacdias mentioned this issue Aug 9, 2023
Merged
@BigLep BigLep moved this to 🔎 In Review in IPFS Shipyard Team Aug 9, 2023
@github-project-automation github-project-automation bot moved this from 🔎 In Review to 🎉 Done in IPFS Shipyard Team Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacdias hacdias

Labels
test:coverage Improves the spec covered by this test suite
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: test 302 /ipns/{legacy-peerid} → /ipns/{cidv1-libp2p-key-base36} ipfs/gateway-conformance
3 participants
@lidel @laurentsenta @hacdias