fix: error when v -0 is present and custom -b is passed && upgrade CID to V1 when custom -b is present and -v is not specified #10143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(commands): return error when -v 0 is present and custom -b is passed test(commands): return error when -v 0 is present and custom -b is passed fix(commands): upgrade CID to V1 when passing a custom -b and no -v is specified test(commands): upgrade CID to V1 when passing a custom -b and no -v is specified
hacdias
requested changes
Sep 26, 2023
There was a problem hiding this comment.
Hey @patrickReiis, thanks for jumping into this! A few notes:
- I pushed a small fix (added
baseStr != "") since you should still be able to call-v 0without specifying a base, in which case the default is used. - Please add a changelog entry to the latest changelog file listed in here: https://github.com/ipfs/kubo/blob/master/CHANGELOG.md
Then it'll likely be ready to merge!
patrickReiis
added a commit
to patrickReiis/kubo
that referenced
this pull request
Sep 26, 2023
|
Hi @hacdias , the current latest is changelog is 0.23 however there's no changelog list in it like changelog 0.22 has for example, so I'll be the first one to add a changelog entry. I'm just warning because I'm not so sure if it's the right thing to do. |
hacdias
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #9556
I'm some sort of beginner when it comes to contributing to open source. I think the tests could be better (I just don't know how), especially the second test since I couldn't read the response body to compare with the expected CID. So in the second test case the only test is really just asserting no error is returned.
I see in the pull request a message telling me to update "docs/changelogs", since I don't know what to update on it I won't touch it.