Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyproject.toml instead of setup.cfg #33

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

ianthomas23
Copy link
Contributor

This PR replaces use of setup.cfg with the equivalent pyproject.toml for PEP 517 compliance.

The setup.py is kept for backward compatibility using the same form as used by various projects in the Jupyter ecosystem, e.g. https://github.com/jupyterlab/jupyterlab/blob/main/setup.py

I have added some extra classifiers for "Jupyter" and also defined the development status as "Production/Stable" as that is what I figure it is. I have removed classifiers for version of Python prior to 3.8 as they have reached end of life (https://devguide.python.org/versions).

@ianthomas23
Copy link
Contributor Author

I have also compared the built sdist and wheel before and after this PR to confirm they are equivalent, and confirmed manually that the installed wheel works with JupyterLab 3 and 4, Notebook 6 and 7, and NbClassic.

pyproject.toml Show resolved Hide resolved
Copy link
Collaborator

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Let's continue discussing the matplotlib optional dependency in #4

@martinRenou martinRenou merged commit 876fe60 into ipython:main Mar 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants