Move Winograd transforms to upstream LLVM?

[GeorgeARM]

Hello all,

We are interested in moving the Winograd transforms to upstream LLVM so that they can be more broadly reusable.
This though comes with a pack of questions :)

First of all would you be happy with us doing this?
If yes, are there any changes that we need to consider functionally before upstreaming?

Thank you in advance,
George

CC: @nicolasvasilache @MaheshRavishankar @Abhishek-Varma @jpienaar

[MaheshRavishankar]

@stellaraccident can chip in about licenses.

With respect to moving this. We probably want to take stock of what the op does today. This op is similar to softmax. It should be implementing the AggregatedOpInterface as well. It might be better to do that in IREE first and make sure things work before moving it upstream.

[RoboTux]

Hi @MaheshRavishankar, could the AggregatedOpInterface added (first in IREE then upstream as suggested) as a second step? It would make for a smaller patch to review and allows to get the winnograd support to upstream quicker.

[MaheshRavishankar]

I think thats fine

[MaheshRavishankar]

(but thanks a lot for looking into moving it. Would be really good to move it and 100% supportive. Just want to make sure we flush things out before moving it)

[stellaraccident]

Nothing special needs to be done to upstream. Just use the upstream license headers. They are compatible.