-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ONNX "resize" op test failures #17345
Comments
FYI @AmosLewis this is the reason why llvm/torch-mlir#3013 was ultimately dropped from the integrate #17330. |
Will you start a new PR to bump it next? Do you have any idea is it a torch-mlir bug or is it an iree bug? |
|
nod-ai/SHARK-ModelDev#616 the model and failure resize mlir are listed in the description |
I don't plan to do it myself. We have an integration rotation schedule and the integrates of this week were already done out-of-schedule :-) |
We have a separate rotation for updating torch-mlir (in fact, @AmosLewis is up for next week 🤔). They are usually updated separately but needed to be updated together in this case. |
Solve iree issue: ONNX "resize" op test failures #17345
Solve iree issue: ONNX "resize" op test failures iree-org#17345
Solve iree issue: ONNX "resize" op test failures iree-org#17345 Signed-off-by: Lubo Litchev <[email protected]>
What happened?
#17330 updates our LLVM and torch-mlir commits, pulling in llvm/torch-mlir#3013. Some tests are newly passing, many tests are still failing somewhere (compiler, runtime numerics), and a few tests are hanging on certain platforms.
At least CUDA is hanging on
test_resize_downsample_scales_linear
:https://github.com/iree-org/iree/actions/runs/9034897378/job/24828864270?pr=17330#step:9:1813
I can't reproduce that on Windows though.
Steps to reproduce your issue
Generally follow the instructions at https://github.com/nod-ai/SHARK-TestSuite/tree/main/iree_tests and pull the config files from this repo.
For example, to run on CUDA:
or Vulkan:
Note that Vulkan has
model.mlir:4:10: error: failed to legalize operation 'arith.fptosi' that was explicitly marked illegal
What component(s) does this issue relate to?
Frontends, Compiler, Runtime
Version information
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: