[tuner]: add property functions to lowering config python binding #19376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhar
reviewed
Dec 5, 2024
kuhar
requested changes
Dec 5, 2024
13 tasks
bangtianliu
changed the title
bangtianliu
changed the title
kuhar
requested changes
Dec 5, 2024
bangtianliu
force-pushed
the
lowering_config_methods
branch
2 times, most recently
from
f96cf54 to
21df5c4
Compare
kuhar
reviewed
Dec 6, 2024
kuhar
reviewed
Dec 6, 2024
kuhar
reviewed
Dec 6, 2024
kuhar
approved these changes
Dec 7, 2024
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUAttrs.h
Outdated
Show resolved
Hide resolved
kuhar
reviewed
Dec 7, 2024
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
bangtianliu
force-pushed
the
lowering_config_methods
branch
from
b34e1d1 to
a080908
Compare
Signed-off-by: Bangtian Liu <[email protected]>
bangtianliu
added a commit
to nod-ai/shark-ai
that referenced
this pull request
Dec 9, 2024
…ng (#662) After landing iree-org/iree#19376, all helper functions related to lowering configuration can be removed. Instead, we can directly utilize property functions from the LoweringConfig Python bindings. This PR is still relevant to the task in #453: use IREE bindings for compilation info (incl., lowering_config and translation_info). --------- Signed-off-by: Bangtian Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces additional property functions to the LoweringConfig Python binding. These new functions enable direct extraction of the following attributes:
workgroup,reduction,subgroup_m_count,subgroup_n_count, andmma_kinddirectly from the lowering config python binding.This PR is relevant to the task in nod-ai/shark-ai#453: use IREE bindings for compilation info (incl., lowering_config and translation_info).