Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not rename rooms #50

Open
batchku opened this issue Mar 16, 2021 · 2 comments
Open

Can not rename rooms #50

batchku opened this issue Mar 16, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@batchku
Copy link
Collaborator

batchku commented Mar 16, 2021

Trying to rename a room by clicking on the room name in the Rooms drawer, but can not

image

@batchku batchku added the bug Something isn't working label Mar 16, 2021
@lazarmitic
Copy link
Contributor

I think by design, you need to click on room edit button that shows up when you hover over room card. In the room dialog that shows up you can change all of the room parameters including name.

Clicking on name switches you to that room currently.

Material UI library does not have any component that will allow me to quickly accomplish this.

I can swap room name paragraph with text input when user clicks on paragraph, but that might not look good since text inputs are much larger that paragraph for room name.

@mericda @batchku If we still want to do this, let me know and I will try to figure something out.

@mericda
Copy link
Contributor

mericda commented Mar 17, 2021

@lazarmitic is correct. Given renaming a room is not a frequent action, we’ve moved it to the edit modal. I’d suggest keeping as it is, but we may consider showing an edit pencil always so that it’s a bit more obvious how to edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants