Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate or remove use of request() method for client #99

Open
isaacgr opened this issue Aug 24, 2021 · 0 comments
Open

Deprecate or remove use of request() method for client #99

isaacgr opened this issue Aug 24, 2021 · 0 comments
Labels
deprecation This issue or pull request deprecates functionality good first issue Good for newcomers

Comments

@isaacgr
Copy link
Owner

isaacgr commented Aug 24, 2021

jaysonic/src/client/protocol/base.js

Line 396 in cffe11b

request() {

This is a legacy method, from back when I was trying some things out with dot methods and classes. Now that .send(), .message() and .notify() exist seperately, its recommended to use those for simplicity.
@isaacgr isaacgr added good first issue Good for newcomers deprecation This issue or pull request deprecates functionality labels Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecation This issue or pull request deprecates functionality good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@isaacgr