Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PATCH as a valid HttpOption method #4

Open
mbark opened this issue Mar 8, 2018 · 1 comment
Open

Support PATCH as a valid HttpOption method #4

mbark opened this issue Mar 8, 2018 · 1 comment

Comments

@mbark
Copy link

mbark commented Mar 8, 2018 •
edited
Loading

Currently the supported methods for HttpOptions are: 'DELETE' | 'GET' | 'HEAD' | 'POST' | 'PUT', however PATCH and OPTIONS are also a valid methods and it would be nice if the the method field in HttpOptions supported them. Right now I'm getting around the problem by simply bypassing the typing with method: <any>'PATCH'.
@mbark mbark changed the title Support 'PATCH' as a valid HttpOption method Support PATCH as a valid HttpOption method Mar 8, 2018
@isaacplmann
Copy link
Owner

You're right those should be added. I'd accept a PR if you want to add that to the types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isaacplmann @mbark