Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orbit from header #40

Open
hfattahi opened this issue May 18, 2022 · 0 comments · May be fixed by #41
Open

Orbit from header #40

hfattahi opened this issue May 18, 2022 · 0 comments · May be fixed by #41
Assignees
Labels
enhancement New feature or request needs triage Issue requires triage to proceed

Comments

@hfattahi
Copy link
Contributor

Checked for duplicates

Yes - I've already checked

Alternatives considered

Yes - and alternatives don't suffice

Related problems

Currently the reader only works if the external orbit file is provided.

Describe the feature request

Since the annotation file already contains the less precise orbit, I think the default behavior should be to extract the orbit from external orbit if the orbit file is provided. If the orbit file is not provided let's just extract the orbit from the header (annotation).

In the annotation file, the orbits are in <generalAnnotation/orbitList> . isce2 implementation can be reused.

@hfattahi hfattahi added enhancement New feature or request needs triage Issue requires triage to proceed labels May 18, 2022
@LiangJYu LiangJYu linked a pull request May 18, 2022 that will close this issue
@LiangJYu LiangJYu linked a pull request May 18, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage Issue requires triage to proceed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants