Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: as_dict method cuts off border polygons on antimeridian #86

Open
scottstanie opened this issue Nov 21, 2022 · 0 comments
Open

[Bug]: as_dict method cuts off border polygons on antimeridian #86

scottstanie opened this issue Nov 21, 2022 · 0 comments
Labels
bug Something isn't working needs triage Issue requires triage to proceed

Comments

@scottstanie
Copy link
Contributor

Checked for duplicates

Yes - I've already checked

Describe the bug

The as_dict code will cut off half the polygon for bursts on the antimeridian (-180 longitude)
https://github.com/opera-adt/s1-reader/blob/main/src/s1reader/s1_burst_slc.py#L367

See opera-adt/burst_db#1

The anti-meridian crossing bursts (international date line) have two polygons, since it's conventional to split the latlon that way.

What did you expect?

The likely fix will be converting to a MultiPolygon which can still be represented as WKT.

Reproducible steps

No response

Environment

No response
@scottstanie scottstanie added bug Something isn't working needs triage Issue requires triage to proceed labels Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage Issue requires triage to proceed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scottstanie