Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

function "Rmatrix3D" contains a critical typo where "incidence angle" is incorrectly written as "back-azimuth" #5

Open
Seismic-wave-Han opened this issue Oct 10, 2023 · 0 comments
Open

function "Rmatrix3D" contains a critical typo where "incidence angle" is incorrectly written as "back-azimuth" #5

Seismic-wave-Han opened this issue Oct 10, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Seismic-wave-Han
Copy link

I am about to use your awesome codes...
However, I found a major typo that may affect the use of 3D rotation.
In the "Rmatrix3D(baz,ain)" function in tools.py (pytheas version 0.2.3)
....
return np.asarray([
[np.cos(baz),-np.sin(ain)*np.sin(baz),-np.sin(ain)*np.cos(baz)],
[np.sin(ain), np.cos(ain)*np.sin(baz), np.cos(ain)*np.cos(baz)],
[0, -np.cos(baz), np.sin(baz)]
])
The rotation conversion matrix is reasonable only when the [0, 0] component of the returned array should be changed to "np.cos(ain)" not "np.cos(baz)".

Thanks!
@Seismic-wave-Han Seismic-wave-Han added the bug Something isn't working label Oct 10, 2023
ispingos added a commit that referenced this issue Aug 20, 2024
@ispingos
[Version 0.3.0+d14] Intallation update and rotation bug fix
1a0bb1c 
- Updated the installation scripts and added a `requirements.txt` file for PIP.
- Updated README.
- Fixed a critical typo in 3D rotation that would lead to unreasonable rotated waveforms (see #5 )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Seismic-wave-Han