Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with deoptimization duplications #9

Open
vivanishin opened this issue Mar 30, 2016 · 1 comment
Open

Deal with deoptimization duplications #9

vivanishin opened this issue Mar 30, 2016 · 1 comment
Labels

Comments

@vivanishin
Copy link
Member

Fix the FIXME in LLVMChunk::SetUpDeoptimizationData:

  // FIXME(llvm): This invariant fails when optimizer duplicates a deopt branch.
  CHECK_EQ(std::set<int>(sorted_ids.begin(), sorted_ids.end()).size(),
           sorted_ids.size());

This behavior manifests on zlib test from Octane benchmark.

Remove irrelevant loads from run.js and run

d8 --llvm-filter=a8 --noturbo-asm run.js 

There were other examples, but I don't have them at hand.

@vivanishin
Copy link
Member Author

Many asm.js programs crash on this CHECK, because they tend to be large. This check can be temporarily disabled to satisfy one's curiosity. Correctness then suffers, but the crashing JS programs tend to terminate successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant