Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header_paths_shortening oversimplifies paths #87

Open
alexian79 opened this issue Dec 10, 2022 · 2 comments
Open

header_paths_shortening oversimplifies paths #87

alexian79 opened this issue Dec 10, 2022 · 2 comments

Comments

@alexian79
Copy link

Hi, thanks for helping me with my previous issue, and would like to report another one.
I am trying to generate board that uses cortex-m4 which is defined in "hw/arm/armv7m.h"
and function that shortens included headers is actually removing too much of the folders in relative path. If I comment out header_paths_shortening call then I have a correct path generated.
image

I have attached sample project that illustrates the issue.

PS. additionally to make it build for version of Qemu I used 7.1.94
I have to replace softmmu_ss to arm_ss like so
image

project.zip

@laerreal
Copy link
Contributor

laerreal commented Dec 12, 2022

Hi! Improved source set selection for new modules (it fixes 2nd part of the issue).

@alexian79
Copy link
Author

alexian79 commented Dec 12, 2022

Thank you, yeah it fixed meson build file generation.

PS. just a small issue, I see that there are 3 instances of using isAlive across the project, but rest of it is already using is_alive. isAlive is an issue with newer python3. not sure is it a problem with python2
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants