Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmartDevice [Windows]: Broken StoreRequest Reply #11

Open
mikyll opened this issue Nov 28, 2022 · 0 comments
Open

SmartDevice [Windows]: Broken StoreRequest Reply #11

mikyll opened this issue Nov 28, 2022 · 0 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@mikyll
Copy link
Contributor

mikyll commented Nov 28, 2022

Problem

The Windows version of the SmartDevice doesn't receive the store_request reply properly: it gets somehow fragmented, therefore the creation of the ApplMessage throws an exception.

Temporary Patch

  • log the message as soon as it's received;
  • catch the exceptions thrown by ApplMessage parsing and log the error message.

Possible Fix

  • use a buffer to store the received messages bits, and create the ApplMessage when all the parameters have been received.
@mikyll mikyll added the bug Something isn't working label Nov 28, 2022
@mikyll mikyll changed the title Bug: Broken StoreRequest **Reply** in SmartDevice Windows Bug: Broken StoreRequest Reply in SmartDevice Windows Nov 28, 2022
@mikyll mikyll added the wontfix This will not be worked on label Mar 5, 2023
@mikyll mikyll changed the title Bug: Broken StoreRequest Reply in SmartDevice Windows SmartDevice [Windows]: Broken StoreRequest Reply Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant