-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin: Add support for comment search by Thread URL in admin interface #1020
admin: Add support for comment search by Thread URL in admin interface #1020
Conversation
6fed88b
to
ba8dffb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Could we perhaps find a better way to convey to admins that they can enter both thread and individual comment URLs?
Also, would it make sense to make the search field a bit smarter and just let it accept plain numbers (for comment ids) as well?
I'm happy to help :)
There is an option to add a tooltip with explanatory text. This will not take up too much space.
Then we will definitely need explanatory text and will have to give up |
Good idea. Something like
On second thought, let's not implement the "smart" search and leave it as is. It would just be confusing. |
I added a tooltip with help text next to the search field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9c53080
to
bf346d1
Compare
Thank you for the review and a nice addition. |
Merged, thanks! |
Checklist
CHANGES.rst
because this is a user-facing change or an important bugfixWhat changes does this Pull Request introduce?
The main theme of the changes is to enhance the comment search functionality in the admin interface. The changes allow searching for comments not only by comment URL but also by thread URL.
Why is this necessary?