You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Appointments marked as nicht_erschienen/missed by the clerk should probably not call a class named WorkstationProcessDelete, as the naming of the class is confusing. In the log table you can't tell if the process was deleted or set to missed by the clerk because WorkstationProcessDelete is written into the log table for either case. Therefore how can you prosecute a case accurately?
Proposal:
Since the class WorkstationProcessDelete is handling both missed and deleted appointments separate the logic into two classes or come up with a more generic class name. A more descriptive name that accurately reflects its purpose and functionality, such as WorkstationProcessMissedHandler might be a good idea.
Benefits:
Improved code clarity
Easier to understand the purpose of the class
Better maintainability and readability
The text was updated successfully, but these errors were encountered:
Description:
Appointments marked as
nicht_erschienen/missed
by the clerk should probably not call a class namedWorkstationProcessDelete
, as the naming of the class is confusing. In the log table you can't tell if the process was deleted or set to missed by the clerk becauseWorkstationProcessDelete
is written into the log table for either case. Therefore how can you prosecute a case accurately?Proposal:
Since the class
WorkstationProcessDelete
is handling both missed and deleted appointments separate the logic into two classes or come up with a more generic class name. A more descriptive name that accurately reflects its purpose and functionality, such asWorkstationProcessMissedHandler
might be a good idea.Benefits:
Improved code clarity
Easier to understand the purpose of the class
Better maintainability and readability
The text was updated successfully, but these errors were encountered: