Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename WorkstationProcessDelete Class for Clarity #483

Open
ThomasAFink opened this issue Jul 4, 2024 · 0 comments
Open

Rename WorkstationProcessDelete Class for Clarity #483

ThomasAFink opened this issue Jul 4, 2024 · 0 comments

Comments

@ThomasAFink
Copy link
Member

ThomasAFink commented Jul 4, 2024

Description:

Appointments marked as nicht_erschienen/missed by the clerk should probably not call a class named WorkstationProcessDelete, as the naming of the class is confusing. In the log table you can't tell if the process was deleted or set to missed by the clerk because WorkstationProcessDelete is written into the log table for either case. Therefore how can you prosecute a case accurately?

Proposal:

Since the class WorkstationProcessDelete is handling both missed and deleted appointments separate the logic into two classes or come up with a more generic class name. A more descriptive name that accurately reflects its purpose and functionality, such as WorkstationProcessMissedHandler might be a good idea.

Benefits:

Improved code clarity
Easier to understand the purpose of the class
Better maintainability and readability

Bildschirmfoto 2024-04-22 um 10 15 05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant