Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to 16.0 #142

Open
zuher83 opened this issue Mar 1, 2023 · 7 comments
Open

Migration to 16.0 #142

zuher83 opened this issue Mar 1, 2023 · 7 comments

Comments

@zuher83
Copy link

zuher83 commented Mar 1, 2023

Thank you for your excellent work for this contribution
Are you planning a migration to 16.0 and if so can we help?
I have already started to migrate... to version 16.0 but I will probably need the help of the community
Can you open a new 16.0 branch to contribute, or is that not in the goals?

Thanks

@zuher83
Copy link
Author

zuher83 commented Mar 29, 2023

I migrated to 16.0 and it works fine 😍. I'm testing again this week. I'm thinking of using it in production mode in 15 days...
I think it will be important to create a new repo with all dependents apps necessary to install on the child databases with by def "get_mandatory_modules(self)"
eg:

  • access_limit_max_users,
  • access_limit_records_number,
  • auth_quick,
  • database_block (I completely rewrote the architecture of the module so as not to depend on "web_responsive" and have a total block of access to the instance)
  • database_expiration
  • database_limit_size
    ...
    My fork repo https://github.com/zuher83/saas-addons
    As soon as the tests are finished I will propose a pull request to migrate 16.0

Features:

  • I will also work to make the UI more friendly for administrators 😎 (kanban views, portal ...)
  • Create a monitoring and alerting system
  • Email templates
  • ...
    In my opinion, it is also necessary to review some aspects of architecture...
    I will keep you informed of the progress in this thread (I feel less lonely) 😊

(Спасибо) thanks it-projects-llc team @em230418 🙏😉

@zuher83 zuher83 changed the title Migration to 16.0 planned? Migration to 16.0 Mar 29, 2023
@ilmir-k
Copy link
Member

ilmir-k commented Mar 30, 2023

Hello @zuher83
Thank you for your contribution. We appreciate it.
We'll let you know once prepare 16.0 branch to be able to PR the updates.

@flotho
Copy link

flotho commented Jun 27, 2023

hi @zuher83 ,
any PR to propose so that we'll be able to help with @gaelTorrecillas

@zuher83
Copy link
Author

zuher83 commented Jul 16, 2023

Ok @flotho, as soon as I can, I make pull request after cleaning the repo

@killday
Copy link

killday commented Sep 2, 2023

Hi @zuher83 does your repo works with v16.0?
I'll give it a go today and try to contribute as much as I can.
Thanks

@zuher83
Copy link
Author

zuher83 commented Sep 15, 2023

Sorry I wasn't available lately, but I'll try to contribute in a few days. Yes it works well for me at the moment

@gaelTorrecillas
Copy link
Contributor

gaelTorrecillas commented Dec 18, 2023

/Hello,

@zuher83 I tested your branch, thanks for your work.

  • config : ok
    I configurated saas with an instance type "remote instance"
  • saas template created a db template : ok
  • I created an instance : KO

When I tried to create an instance, job 'saas.db.create_db' returned :


Traceback (most recent call last):
  File "/home/DEV/Odoo_Server_And_Libs/Libs_16.0/OCA-queue/queue_job/controllers/main.py", line 104, in runjob
    self._try_perform_job(env, job)
  File "/home/DEV/Odoo_Server_And_Libs/Libs_16.0/OCA-queue/queue_job/controllers/main.py", line 36, in _try_perform_job
    job.perform()
  File "/home/DEV/Odoo_Server_And_Libs/Libs_16.0/OCA-queue/queue_job/job.py", line 517, in perform
    self.result = self.func(*tuple(self.args), **self.kwargs)
  File "/home/DEV/Odoo_Server_And_Libs/Libs_16.0/saas-addons/saas/models/saas_db.py", line 36, in create_db
    self.state = 'done'
  File "/home/DEV/_ProjetsOdoo/odoo_16/odoo/odoo/fields.py", line 1324, in __set__
    records.write({self.name: write_value})
  File "/home/DEV/Odoo_Server_And_Libs/Libs_16.0/saas-addons/saas/models/saas_db.py", line 64, in write
    self.refresh_data()
  File "/home/DEV/Odoo_Server_And_Libs/Libs_16.0/saas-addons/saas/models/saas_db.py", line 77, in refresh_data
    record.operator_id._signal_changes(record.name)
  File "/home/DEV/Odoo_Server_And_Libs/Libs_16.0/saas-addons/saas_operator_remote/models/saas_operator.py", line 163, in _signal_changes
    response = jsonrpc(
  File "/home/DEV/Odoo_Server_And_Libs/Libs_16.0/saas-addons/saas_operator_remote/models/saas_operator.py", line 29, in jsonrpc
    raise Exception(message)
Exception: ==========
REMOTE INSTANCE TRACEBACK
==========
Traceback (most recent call last):
  File "/home/DEV/_ProjetsOdoo/odoo_16/odoo/odoo/http.py", line 1591, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "/home/DEV/_ProjetsOdoo/odoo_16/odoo/odoo/service/model.py", line 133, in retrying
    result = func()
  File "/home/DEV/_ProjetsOdoo/odoo_16/odoo/odoo/http.py", line 1618, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "/home/DEV/_ProjetsOdoo/odoo_16/odoo/odoo/http.py", line 1822, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "/home/DEV/_ProjetsOdoo/odoo_16/odoo/odoo/addons/base/models/ir_http.py", line 154, in _dispatch
    result = endpoint(**request.params)
  File "/home/DEV/_ProjetsOdoo/odoo_16/odoo/odoo/http.py", line 697, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/home/DEV/Odoo_Server_And_Libs/Libs_16.0/saas-addons/saas_cluster_simple/controllers/main.py", line 25, in wrap
    return f(*args, **kw)
  File "/home/DEV/Odoo_Server_And_Libs/Libs_16.0/saas-addons/saas_cluster_simple/controllers/main.py", line 35, in run_cluster_method
    return method(**kw)
TypeError: signal_changes() got an unexpected keyword argument 'db_name' 

blocking further execution. However in postgresql, the database is well created. I can't determine the origin of the problem.

Did you have this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants