Dvorak / Workshop required fields move #2647
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humanmantis
requested changes
Oct 29, 2024
src/app/shared/components/institution-hierarchy/institution-hierarchy.component.ts
Show resolved
Hide resolved
src/app/shared/components/institution-hierarchy/institution-hierarchy.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/components/institution-hierarchy/institution-hierarchy.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/components/institution-hierarchy/institution-hierarchy.component.ts
Outdated
Show resolved
Hide resolved
...l/personal-cabinet/provider/create-workshop/create-about-form/create-about-form.component.ts
Show resolved
Hide resolved
...abinet/provider/create-workshop/create-description-form/create-description-form.component.ts
Outdated
Show resolved
Hide resolved
|
humanmantis
reviewed
Nov 19, 2024
| @@ -73,6 +76,7 @@ export class InstitutionHierarchyComponent implements OnInit, OnDestroy { | |||
| this.hierarchyArray = this.hierarchyArray.slice(0, nextEl); | |||
| this.setFinalHierarchyLevel(null); | |||
| } | |||
| this.changeDetectorRef.detectChanges(); | |||
There was a problem hiding this comment.
Can we use markForCheck instead here and in other places?
humanmantis
reviewed
Nov 19, 2024
| <label class="step-characters-count"> | ||
| <ng-container *ngIf="DescriptionFormGroup.get('competitiveSelectionDescription').value; else elseBlock"> | ||
| {{ DescriptionFormGroup.get('competitiveSelectionDescription').value?.length }}/{{ | ||
| validationConstants.MAX_DESCRIPTION_LENGTH_500 |
There was a problem hiding this comment.
This formatting looks odd
humanmantis
reviewed
Nov 19, 2024
| matInput | ||
| class="step-textarea step-textarea-short" | ||
| placeholder="{{ 'FORMS.PLACEHOLDERS.MAXIMUM' | translate }} {{ validationConstants.MAX_DESCRIPTION_LENGTH_500 }} {{ | ||
| 'FORMS.PLACEHOLDERS.SYMBOLS' | translate |
There was a problem hiding this comment.
This formatting looks odd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved required fields while creating/editing workshop to the first page of workshop creation. And also moved some fields that are not required to the second page