fix/527_highlight_header_tab #535
Conversation
|
Your Render PR Server URL is https://zero-waste-staging-pr-535.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cj4k4k76bdogf874u420. |
AndriyAndriyovuch
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #535 +/- ##
===========================================
- Coverage 85.34% 76.43% -8.92%
===========================================
Files 64 64
Lines 778 802 +24
===========================================
- Hits 664 613 -51
- Misses 114 189 +75 ☔ View full report in Codecov by Sentry. |
| @@ -208,6 +208,11 @@ h3.container { | |||
| padding: 20px; | |||
| } | |||
|
|
|||
| .tab-active { | |||
| color: darkgreen!important; | |||
There was a problem hiding this comment.
| color: darkgreen!important; | |
| color: darkgreen !important; |
| @@ -0,0 +1,91 @@ | |||
| <nav class="navbar navbar-expand-lg navbar-light bg-light border-bottom border-success"> | |||
| <div class="container-fluid"> | |||
| <%= link_to root_path, class: 'logo-zerowaste' do %> | |||
There was a problem hiding this comment.
і так скрізь у цьому файлі
| <nav class="navbar navbar-expand-lg navbar-light bg-light border-bottom border-success"> | ||
| <div class="container-fluid"> | ||
| <%= link_to root_path, class: 'logo-zerowaste' do %> | ||
| <%= image_tag('logo_zerowaste.png') %> |
There was a problem hiding this comment.
і так скрізь у цьому файлі
| </div> | ||
|
|
||
| <div class="d-flex order-lg-1"> | ||
| <div class="mr-3 align-middle" id="lang-btn"> |
| <ul class="navbar-nav mr-0"> | ||
| <li class="nav-item mx-3"> | ||
| <%= link_to_unless_current t('.calculators'), account_calculators_path, class: "navbar-brand text-success h3" do %> | ||
| <span class="navbar-brand h3 tab-active"> |
There was a problem hiding this comment.
а для чого їх всіх в спан огортати? не бачу сенсу
| <nav class="navbar navbar-expand-lg navbar-light bg-light border-bottom border-success"> | ||
| <div class="container-fluid"> | ||
| <%= link_to root_path, title: t('.homepage'), class: 'logo-zerowaste' do %> | ||
| <%= image_tag('logo_zerowaste.png', alt: "ZeroWaste_logo")%> |
There was a problem hiding this comment.
без андерлайн і має бути локалізація, бо це буде читатися людям з проблемами зору
| </li> | ||
|
|
||
| <li class="nav-item mx-3"> | ||
| <%= link_to_unless_current t('.app_config'), edit_account_app_config_path, title: t('.app_config'), class: "navbar-brand text-success h3" do %> |
…ocale for language selection, remove useless classes
|
Kudos, SonarCloud Quality Gate passed!
|
Code reviewers
Summary of issue
Highlight active tab on admin panel
Summary of change
CHECK LIST
Before:
After: