Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid function names when printing OpenSSL errors #133

Commits on Jun 13, 2024

  1. Return true/false from a function returning bool

    Return false in case the certificate is about to expire, causing the
    (only) caller to subsequently verify the proxy.
    giacomini committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    30d6817 View commit details
    Browse the repository at this point in the history
  2. Fix how the read mode is specified to access

    The mode passed to access is an int and not a string, like in fopen.
    giacomini committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    a3eaa5c View commit details
    Browse the repository at this point in the history
  3. Simplify the production of the SSL error message

    Just rely on the canonical loop over the error stack, without special
    treatment for an expired certificate, which is caught somewhere else in
    any case.
    Be sure that the data added to an error is a text string before printing
    it.
    giacomini committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    1f25a6d View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Remove commented out code

    The code mentions OpenSSL functions related to error management, which
    has changed in OpenSSL 3, deprecating old practices.
    giacomini committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    cd5c735 View commit details
    Browse the repository at this point in the history
  2. Ignore the function name in OpenSSL errors

    The use of the function name in errors has been abandoned in OpenSSL 3.
    Profit to replace the use of sprintf with snprintf.
    giacomini committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    8866b95 View commit details
    Browse the repository at this point in the history
  3. Re-format the output of an SSL error message

    To be more compatible with how it was done before.
    giacomini committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ac778b8 View commit details
    Browse the repository at this point in the history