You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I took a look why the tests are failing, but I don't know how difficult it is to fix them.
The following tests break in lua5.1 and lua5.2 because until lua5.3 the table library don't respect metamethods for getting and settings elements (see lua 5.3 manual). So table.insert don't invoke the __newindex metamethod:
immutable output is as expected gives an error on table insert
immutable output is as expected gives an error on table remove
proxy creates expected behavior newindex is always called
set output is as expected doesn't add repetead values
And the followings tests break in lua5.1 because of the lack of __pairs:
proxy creates expected behavior allows to protect value set
set output is as expected removes repeated values
set output is as expected doesn't add repetead values
This is quite a nice sumary of the issue @imolein
So, we have two problems, with different levels of complexity, here that could be solved separately. For problem 1, patching table functions could probably solve the issue, although this is probably far from trivial. Might also not work with luajit (maybeeeeee). (I say this but have no clue how to do it). For problem 2, would you like to propose a solution? Just adding a __pairs method made it work for you?
Just noticed some tests break for lua5.1, lua5.2 and luajit. Trying to cook up proper fix.
The text was updated successfully, but these errors were encountered: