Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wallet_getCapabilities #99

Open
onbjerg opened this issue Nov 26, 2024 · 2 comments · May be fixed by #104
Open

Remove wallet_getCapabilities #99

onbjerg opened this issue Nov 26, 2024 · 2 comments · May be fixed by #104
Assignees
@varun-doshi
Labels
A-wallet C-debt D-good-first-issue Good for newcomers

Comments

@onbjerg
Copy link
Member

onbjerg commented Nov 26, 2024

This is no longer used, so we can simplify quite a bit by just removing it. The only hurdle here is that we use it in e2e tests to get the delegation contract - however, any contract here will do, so we just need to adjust the tests to take e.g. an a contract address as an env var, or hardcode it.
@varun-doshi
Copy link

varun-doshi commented Nov 26, 2024 •
edited
Loading

I can take this

@onbjerg
Copy link
Member Author

onbjerg commented Nov 26, 2024

Thanks! I've assigned you to the issue. If you feel stuck, open up a draft PR with your questions and someone will help you. If you are prevented from solving the issue, let me know and I will unassign you 😄

@varun-doshi varun-doshi linked a pull request Nov 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varun-doshi varun-doshi

Labels
A-wallet C-debt D-good-first-issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: removed wallet_getCapabilities varun-doshi/odyssey
2 participants
@onbjerg @varun-doshi