Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bookmarks may be broken when upgrading dictionnary files #136

Open
d-faure opened this issue Feb 21, 2022 · 2 comments
Open

bookmarks may be broken when upgrading dictionnary files #136

d-faure opened this issue Feb 21, 2022 · 2 comments

Comments

@d-faure
Copy link

d-faure commented Feb 21, 2022

When installing new versions of dictionary files, some bookmarks may be unable to reach their (new) location.

Whereas this may be obvious that reworked articles from a release to another one should be difficult/impossible to be reachable using old bookmarks, there isn't any convenient mean to start a new search from the old bookmark title.

This is the kind of tiny quality of life improvement that the application could benefit

@itkach
Copy link
Owner

itkach commented Feb 25, 2022

Bookmarks do not record dictionary file location. Dictionary in a bookmark is identified by uri tag, so that bookmark continues to work even if specific dictionary (e.g. English Wikipedia) is updated to a new version (assuming new version still contains article with the bookmarked title). Sounds like this is mostly a theoretical concern. Am I missing something?

@francwalter
Copy link

Indeed I made the same experience: after each update of German wiki most of bookmarks are broken.

It is very unlikely that the links changed, though I didn't scrutinize that. How, anyway? I would need to compile the app and debug in Android studio, I guess.

I searched then the few important ones again manually and bookmarked them again. Leading to the conclusion that there are fewer and fewer really important bookmarks ;)

It's not too important to me anymore, anyway :)
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants